[Extensions.Enrichment] Rename some AddTraceEnricher methods to TryAddTraceEnricher #3085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3085 +/- ##
==========================================
+ Coverage 69.60% 69.80% +0.19%
==========================================
Files 420 410 -10
Lines 16317 16199 -118
==========================================
- Hits 11358 11308 -50
+ Misses 4959 4891 -68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
evgenyfedorov2
force-pushed
the
users/evgenyfedorov2/rename_enrichnment_extensions
branch
from
bfcb200 to
9418308
Compare
evgenyfedorov2
force-pushed
the
users/evgenyfedorov2/rename_enrichnment_extensions
branch
from
9418308 to
c7344d1
Compare
dariusclay
approved these changes
Sep 9, 2025
Contributor
dariusclay
left a comment
dariusclay
left a comment
There was a problem hiding this comment.
LGTM, better naming to match underlying behavior
Kielek
reviewed
Sep 9, 2025
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Kielek
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renamed some extension methods from
AddTraceEnricher*toTryAddTraceEnricher*to better convey the idea of idempotency -duplicate registrations are not allowed nor make sense.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes